[webkit-dev] MathML renderer

[Maciej Stachowiak]

On Jan 4, 2011, at 7:09 PM, Alex Milowski wrote:

> On Tue, Jan 4, 2011 at 1:50 PM, Maciej Stachowiak <mjs at apple.com> wrote:
>> 
>> On Jan 4, 2011, at 11:03 AM, Dirk Schulze wrote:
>> 
>>> Hi webkit-dev,
>>> 
>>> I was looking at the MathML code recently and I wonder, that all files are located at WebCore/mathml, even the renderer. Shouldn't the rendering code be moved to WebCore/rendering/? Or better WebCore/rendering/mathml/?
>> 
>> Yes, the rendering code would be better placed in the rendering/ directory.
> 
> Well, not to buck the trend, but ...
> 
> I actually prefer having it all under the 'mathml' directory so that
> is what I did.  No one has complained before.
> 
> If there is a strong preference to move the RenderMathML* files to
> WebCore/rendering/, I'm not against it.

In general, the approach we've taken is to put all rendering code in WebCore, and the DOM aspect of each markup language in its own directory. I can see how there could be benefits to keeping it all together, but I think it's more important to stay consistent with the rest of the project.

It might make sense to use subdirectories of rendering/, as svg has started to (although this seems incomplete - SVG folks, is the plan to move the remaining SVG-related rendering files from rendering/ to rendering/svg?).

Regards,
Maciej

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110104/22d1d181/attachment.html>