[webkit-dev] code review tool changes

Ryosuke Niwa rniwa at webkit.org
Wed Feb 2 11:41:17 PST 2011


On Tue, Feb 1, 2011 at 5:09 PM, Ojan Vafai <ojan at chromium.org> wrote:
>
> -Side-by-side diffs: You can view the entire diff or individual files in
> side-by-side diff. If you change the entire diff, we'll store that in
> localstorage and load diffs in side-by-side by default.
> -Comments and diff navigation: n/p keys will navigate to the next/previous
> comment. j/k will navigate to the next/previous diff.
> -Draft comments persist: draft comments are now stored in localstorage, so
> they will persist across reloads, crashes, etc. Since it's in localstorage
> it's stored per-machine.*
> -Expand diff context: You can expand the lines above/below a diff to see
> more context.**
>
> Hope this works well for you all. Obviously, file bugs if something isn't
> working.
>

On Tue, Feb 1, 2011 at 6:07 PM, Ojan Vafai <ojan at chromium.org> wrote:

> Forgot one. Comments from the style checker are also shown in the code
> review tool now.
>

These are great features. Being able to quickly switch between unified diffs
and side-by-side diffs has been very useful.  Thanks for the improvements.

- Ryosuke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110202/9c9d9890/attachment.html>


More information about the webkit-dev mailing list