[webkit-dev] [PATCH] JSCore with GDB

paroga at paroga.com paroga at paroga.com
Thu Dec 29 04:29:47 PST 2011


On Thu, 29 Dec 2011 17:41:57 +0530, Sanjoy Das wrote:
> Small hiccup: to work with GDB I need the following declarations in a
> source file:
> void __attribute__((noinline)) __jit_debug_register_code() { };
> JITDescriptor __jit_debug_descriptor = { 1, 0, 0, 0 };
> This fails the style checker.  Does it make sense to add the file to
> _SKIPPED_FILES_WITH_WARNING?  Is there some better way to fix this?

_SKIPPED_FILES_WITH_WARNING is usually used for files imported from 
ohter repositories, which follow other style guidelines
If it's only a hand full of lines you can ignore it, if there is no 
"good" way to fix it. Do you need the "__" prefix, or what's the exact 
problem with the line?
For the noinline attribute exists the NEVER_INLINE macro in WebKit.

Maybe you can upload the patch to a bugzilla bug, and only post the 
bugid here so people can CC there, and we don't need to spam the list 
for such specific questions.

- Patrick

More information about the webkit-dev mailing list