[webkit-dev] js-test-(pre|post).js in http tests

Eric Seidel eric at webkit.org
Mon Dec 19 16:33:14 PST 2011

Yes we certainly have many useless/broken tests in the repository.
Alexey is correct, that it's difficult to tell when a test is useless
however. :)


On Mon, Dec 19, 2011 at 6:16 PM, Benjamin Poulain <benjamin at webkit.org> wrote:
> 2011/12/19 Alexey Proskuryakov <ap at webkit.org>:
>> Generally speaking, I think that it's not worth it making existing tests
>> pretty for the sake of prettiness or even consistency. It is very easy to
>> lose some intended non-obvious properties of tests that way, as well as to
>> lose unintended testing. We certainly don't want to only test HTML and JS
>> code that adheres to WebKit style guide!
>> There are certainly many situations where it makes great sense to rework
>> tests. Making results cross-platform (for example by switching to text-only
>> or to reftests) is something that is always very welcome.
> I am sure there is plenty of room for improvement.
> E.g.:
> -https://bugs.webkit.org/show_bug.cgi?id=71091 (the test did not do anything)
> -https://bugs.webkit.org/show_bug.cgi?id=70672 (the test was not
> testing what it was supposed to test)
> Benjamin
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

More information about the webkit-dev mailing list