[webkit-dev] Top Crasher: Shadow DOM and Editing Collide Again

Ryosuke Niwa rniwa at webkit.org
Mon Aug 29 14:34:56 PDT 2011

On Mon, Aug 29, 2011 at 1:46 PM, Dimitri Glazkov <dglazkov at chromium.org>wrote:
> I just realized what's going on here. The lifetime of the shadow DOM
> _used_ to be tied to the HTMLTextAreaElement's RenderObjects. Kent-san
> changed that and now the shadow DOM's lifecycle matches that of the
> rest of the DOM.


> However, the update cycle still assumes that the
> shadow DOM lives on the RenderObjects, and does this really freaky
> thing with shuttling updated value via an extra style recalc (see
> http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/html/HTMLTextAreaElement.cpp&l=349
> ).
> We should just fix that and move updating code out of
> updateFromElement.

Right.  I think making updateFromElement not call setInnerTextValue will fix
this bug for good.

- Ryosuke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110829/b1e09752/attachment.html>

More information about the webkit-dev mailing list