[webkit-dev] Chromium Mac moving to Skia
abarth at webkit.org
Tue Aug 16 14:16:51 PDT 2011
On Tue, Aug 16, 2011 at 2:06 PM, Maciej Stachowiak <mjs at apple.com> wrote:
> On Aug 16, 2011, at 11:31 AM, Adam Barth wrote:
>> Hi WebKit,
>> In an effort to make the Chromium port more consistent across
>> platforms, we're moving the Chromium Mac port from CoreGraphics to
>> Skia. This should mostly have little effect on the rest of the WebKit
>> community, but you'll be seeing some patches shortly that shuffle a
>> bunch of test expectations around so that we can make the transition
>> carefully and avoid regressions. Specifically, we're planing to do
>> the following:
>> 1) Move the chromium-mac and chromium-mac-leopard results directories
>> to chromium-mac-cg and chromium-mac-cg-leopard, respectively. This
>> will let use keep both CG and Skia results during the transition so
>> that we can compare them and avoid regressions.
> How long would you expect to keep both around?
That depends on the quality of the Skia configuration, but hopefully
on the order of a month. Having the CG results preserves the option
of continuing to ship the CG configuration. Once the Chromium project
doesn't need that option any more, we can remove the CG baselines.
> Currently half the platform results directories are Chromium, comprising a third of the LayoutTests/platform directory and a quarter of all of LayoutTests. These results directories also tend to change far more frequently than others. I am worried about the long-term impact of adding even more Chromium results, since svn update times are already very high and typically spend a large proportion of their time updating Chromium expectations. Do you have an estimate of the impact on checkout times?
The net result of this process should be fewer files overall for the
Chromium expectations because more results can be shared between the
various platforms Chromium runs on. I do not have an estimate on the
impact on checkout times, either for the transition or for after the
CG results are removed.
Another approach is to teach update-webkit how to create a partial
checkout that contains only those result directories that the
developer is using. For example, if you're working on the
apple-mac-leopard port, you'd only need platform/mac,
platform/mac-snowlepard, and platform/mac-leopard and wouldn't need
any of the Win, GTK, Qt, or Chromium expected results.
More information about the webkit-dev