[webkit-dev] WebKit2 build system

[David Levin]

Question answered (in irc): WebKit2 files should have config.h

Thanks!

On Mon, Apr 11, 2011 at 9:58 AM, David Levin <levin at google.com> wrote:

> Hi,
> I was looking at a patch (https://bugs.webkit.org/show_bug.cgi?id=57535)
> in which it uses the OS() macro in some headers (to add a conditional
> include to define time_t).
>
> Unfortunately, when these headers are included from WebKit2 files, the
> build breaks (on various platforms) because OS() isn't defined. Typically
> OS() is defined by including config.h but that file doesn't seem to be in
> the cpp files for WebKit2.
>
> What is the proper way of fixing this?
>
>    - include wtf/Platform.h directly in the header files affected (which
>    seem wrong to me).
>    - include config.h in WebKit2 files (but this appears not to be done).
>    - other?
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110411/8184ae10/attachment.html>