[webkit-dev] Who are the EFL reviewers?

[David Levin]

On Mon, Apr 11, 2011 at 3:40 AM, Tomasz Morawski <t.morawski at samsung.com>wrote:

> Hi,
> Is it possible to promote some other peoples to reviewers in the EFL
> port?
>

A step that I usually suggest to chromium folks before becoming reviewers is
to actually do reviews on patches.  Do everything except the r+ (with the
submitter's permission).

These are helpful to show when the reviewer nomination happens (as
supporting evidence). If there are folks in the efl community who feel that
they like to be reviewers, perhaps they can start doing this.  (Then someone
who is a reviewer can come along and give the final r+. I view it as a kind
of mentorship thing because the reviewer should do a review as well and then
the original person can learn from that if there were things that they
missed.)

dave


> Tomasz
>
>
>  The problem is that as I am not working on the port myself, I find it
>> quite hard to review their API's without getting input from someone
>> else working on EFL.
>>
>> I think Antonio feels likewise.
>>
>> Kenneth
>>
>> On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomes<tonikitoo at gmail.com>
>>  wrote:
>>
>>> Mostly myself and Kenneth. We do what we can, but we also to work on our
>>> stuff (as everybody else :). It really needs other reviewers to help out
>>> with reviewing, since EFL port guys are working really hard on it.
>>>
>>> On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidel<eric at webkit.org>  wrote:
>>>
>>>>
>>>> We seem to have a zillion EFL patches up for review.
>>>> Who are the EFL reviewers?
>>>> (I think part of the trouble is that it seems the EFL port is trying to
>>>> do
>>>> too much in WebKit.  I'm not sure where the EFL browser is, but some of
>>>> the
>>>> patches look like they should be re-directed to that project instead of
>>>> WebKit.)
>>>> -eric
>>>> _______________________________________________
>>>> webkit-dev mailing list
>>>> webkit-dev at lists.webkit.org
>>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>>
>>>>
>>>
>>>
>>> --
>>> --Antonio Gomes
>>>
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>>>
>>
>>
>>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110411/b9e88bb4/attachment.html>