[webkit-dev] Disallowing modal dialogs during unload events

Darin Fisher darin at chromium.org
Thu Apr 7 10:21:45 PDT 2011


As you know, I'm a very strong advocate of this change.  I think even if
other
ports aren't interested in experimenting with this change at the current
time,
that we should proceed to experiment with it in Chromium.  I would very much
like us to have data about how many sites are impacted, so that we can share
that with others.

-Darin


On Wed, Apr 6, 2011 at 4:37 PM, Sreeram Ramachandran <sreeram at google.com>wrote:

> We'd like to disallow modal dialogs (i.e., those arising from calls to
> alert, confirm, prompt or showModalDialog) during unload events
> (beforeunload, unload and pagehide) [1]. Chromium wants to do this
> [2]. Since this affects web compatibility, I'd like to get agreement
> from the other webkit ports as well.
>
> The benefits are:
> + Fewer annoyances for users who are trying to leave a page.
> + In the case of tab close, allows the browser to hide the tab before
> it has finished running the unload or pagehide event handlers (doesn't
> apply to beforeunload); gives the impression of better performance.
>
> This doesn't affect returning a non-null value from beforeunload; that
> will still cause the browser to show the stay-or-leave dialog. We
> think that is sufficient to satisfy legitimate needs to warn the user
> about data loss, etc.
>
> Outside webkit, this has been discussed on whatwg, but without a
> definite conclusion [3]. Firefox seems to be considering this as well
> [4].
>
> All in favour, say aye!
>
> [1] https://bugs.webkit.org/show_bug.cgi?id=56397
> [2] http://code.google.com/p/chromium/issues/detail?id=68780
> [3]
> http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2010-February/025080.html
> [4] https://bugzilla.mozilla.org/show_bug.cgi?id=391834
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20110407/eb066bda/attachment.html>


More information about the webkit-dev mailing list