[webkit-dev] Review tool changes

Maciej Stachowiak mjs at apple.com
Mon Sep 20 11:33:19 PDT 2010

On Sep 20, 2010, at 10:22 AM, Darin Fisher wrote:

> On Mon, Sep 20, 2010 at 10:10 AM, Adam Barth <abarth at webkit.org> wrote:
> On Mon, Sep 20, 2010 at 8:37 AM, Alexey Proskuryakov <ap at webkit.org> wrote:
> > 16.09.2010, в 18:39, Darin Fisher написал(а):
> >> Push the publish button to review your comments :-)
> >
> > Alas, not any more!
> >
> > https://bugs.webkit.org/show_bug.cgi?id=46074
> Yeah.  The machinery is still there for the preview, I'm just not sure
> what the best UI is for triggering it.
> Adam
> How about this?
> If any annotations were made to the patch, then "the button" gets named Preview.  Else, the button is named "Publish" and when clicked performs its work in one shot.
> Was there a strong outcry for removing the preview step?  I only found it bothersome when I wanted to issue a quick r=me on a patch that didn't require any additional changes.

How about having both [Publish] and [Preview] buttons?

Or honestly, I think it would be fine to have just [Preview]. If a blog can require you to check what you posted before it appears in comments, then I think it is a reasonable requirement for a patch review system.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100920/1ade9a60/attachment.html>

More information about the webkit-dev mailing list