[webkit-dev] [webkit-changes] [67188] trunk/WebKit/chromium

[Adam Barth]

Interesting.  If you look at the patch:

https://bugs.webkit.org/attachment.cgi?id=67061&action=prettypatch

You'll see a stray minus line in the ChangeLog.  That must have
confused the bot.  We'll add another validation step to prevent this
case.  Thanks for the report.

Adam


On Fri, Sep 10, 2010 at 9:53 AM, Alexey Proskuryakov <ap at webkit.org> wrote:
>
> Do we know why this (incorrect commit messages) happens? With the new
> support for committer name rewriting, this has become even more confusing.
> - WBR, Alexey Proskuryakov
> 10.09.2010, в 4:36, darin at apple.com написал(а):
>
> Revision 67188 Author darin at apple.com Date 2010-09-10 04:36:40 -0700 (Fri,
> 10 Sep 2010)
>
> Log Message
>
> 2010-09-08  Darin Adler  <darin at apple.com>
>
>         Reviewed by Adam Barth.
>
>         Move functions from Frame to Editor as planned
>         https://bugs.webkit.org/show_bug.cgi?id=45218
>
>         * src/ContextMenuClientImpl.cpp:
>         (WebKit::selectMisspelledWord):
>         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
>         * src/WebFrameImpl.cpp:
>         (WebKit::WebFrameImpl::find):
>         (WebKit::WebFrameImpl::stopFinding):
>         (WebKit::WebFrameImpl::scopeStringMatches):
>         * src/WebViewImpl.cpp:
>         (WebKit::WebViewImpl::caretOrSelectionBounds):
>         Changed call sites to use editor().
>
> Modified Paths
>
> trunk/WebKit/chromium/ChangeLog
> trunk/WebKit/chromium/public/WebDOMEvent.h
>
> Diff
>
> Modified: trunk/WebKit/chromium/ChangeLog (67187 => 67188)
>
> --- trunk/WebKit/chromium/ChangeLog	2010-09-10 10:57:49 UTC (rev 67187)
> +++ trunk/WebKit/chromium/ChangeLog	2010-09-10 11:36:40 UTC (rev 67188)
> @@ -53,13 +53,22 @@
>          * src/WebKit.cpp:
>          (WebKit::areLayoutTestImagesOpaque): Make linux match windows.
>
> +2010-09-10  Jay Civelli  <jcivelli at chromium.org>
> +
> +        Reviewed by Darin Fisher.
> +
> +        Add the destructor to WebDOMEvent to prevent a leak.
> +        https://bugs.webkit.org/show_bug.cgi?id=45287
> +
> +        * public/WebDOMEvent.h:
> +        (WebKit::WebDOMEvent::~WebDOMEvent):
> +
>  2010-09-09  Chris Guillory  <chris.guillory at google.com>
>
>          Reviewed by Chris Fleizach.
>
>          Add methods used to determine accessibility state.
>          https://bugs.webkit.org/show_bug.cgi?id=45434
> -
>
>          * public/WebAccessibilityObject.h:
>          * src/WebAccessibilityObject.cpp:
>
> Modified: trunk/WebKit/chromium/public/WebDOMEvent.h (67187 => 67188)
>
> --- trunk/WebKit/chromium/public/WebDOMEvent.h	2010-09-10 10:57:49 UTC (rev
> 67187)
> +++ trunk/WebKit/chromium/public/WebDOMEvent.h	2010-09-10 11:36:40 UTC (rev
> 67188)
> @@ -50,6 +50,8 @@
>          BubblingPhase      = 3
>      };
>
> +    ~WebDOMEvent() { reset(); }
> +
>      WebDOMEvent() : m_private(0) { }
>      WebDOMEvent(const WebDOMEvent& e) : m_private(0) { assign(e); }
>      WebDOMEvent& operator=(const WebDOMEvent& e)
>
> _______________________________________________
> webkit-changes mailing list
> webkit-changes at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>