[webkit-dev] attached()

[Eric Seidel]

You would know this code better than I:
http://trac.webkit.org/browser/trunk/WebCore/dom/Node.cpp#L747

It's not clear to me how lazyAttach() ends up calling attach in the
end (or if it does).  It seems impossible that it would end up calling
attach later since lazyAttach normally marks elements as attached().
However since many elements override attach() the lazyAttach() code
path might be doing the wrong thing for many elements.

Again, I'm not changing when lazyAttach() is called, just making
<frame>/<object> be lazy-attach-safe.  I'm glad we're having this
discussion though as I would like to make a wider deployment of
lazyAttach after this lands.  I think it could be a PLT win (and
certainly a parser benchmark win!)

On Thu, Sep 9, 2010 at 10:23 AM, David Hyatt <hyatt at apple.com> wrote:
> On Sep 9, 2010, at 12:17 PM, Eric Seidel wrote:
>
>>
>> I'm not sure what you mean.  You mean that the change in my patch to
>> run the lazyAttach logic from insertedIntoDocument may cause
>> additional style recalcs?  The new element needs style calculated
>> regardless.  Marking an element with childNeedsStyleRecalc doesn't
>> recalculate the style for that object to my knowledge.
>
> Oh I thought lazyAttach was actually marking nodes as needing a full style recalc.  If it's not then I guess that's fine.
>
> dave
>
>