[webkit-dev] attached()

Maciej Stachowiak mjs at apple.com
Thu Sep 9 00:43:04 PDT 2010

On Sep 9, 2010, at 12:00 AM, Eric Seidel wrote:

> I'm about to remove the last non-lazy attaching element.
> https://bugs.webkit.org/show_bug.cgi?id=45365
> I think we can now kill the whole concept of being "attached".
> attached() does not necessarily mean you have a renderer.  It just
> means that something called attach() or lazyAttach() on you.
> Instead, we could change all elements to mark themselves (and their
> parents) as needing style recalc during insertedIntoDocument(),
> effectively "attaching/lazyAttaching".

Presumably they should mark their parents as "child needs style recalc", not needing recalc themselves.

> (We could also fix the current lazyAttach() code to check to see if a
> parent is already marked with a child needing style resolve, and stop
> walking to prevent N^2 behavior.)
> I'm not sure if it would make sense to keep the "attached" flag around
> to make sure the attach logic is never run twice.

Do any attach() methods still do nontrivial work? Is it an error to call it twice, or not properly paired up with detach()?


More information about the webkit-dev mailing list