[webkit-dev] [svg] rect with invalid stroke value

[Yuzo Fujishima]

Any updates?

If I don't see any objections within 24 hours, preferably with the
commitment to fix the SVG bug :),
I'll modify the test and commit the patch for
https://bugs.webkit.org/show_bug.cgi?id=24742

My rationale:
- No actions observed for more than 2 months
- Modifying the test doesn't harm the test's intention, as indicated by the
name of the tests.
- Not fixing a bug because of another bug no one is actively working on
doesn't make sense to me.

Yuzo



On Mon, Jun 28, 2010 at 2:54 PM, Dirk Schulze <vbs85 at gmx.de> wrote:

> Hi Yuzo,

> the issue should be fixed in WebCore/rendering/RenderSVGPaintServer.
> Removing this check in the test doesn't help to fix the bug :-)

> Dirk

> Am Montag, den 28.06.2010, 11:05 +0900 schrieb Yuzo Fujishima:
> > Hi,
> >
> >
> > Any update on this?
> >
> >
> > Is it OK to remove 'stroke="#0"' from:
> >   LayoutTests/svg/custom/invalid-fill-hex.svg
> >     <rect width="100" height="100" fill="#ff" stroke="#0"/>
> > ?
> >
> >
> > If there are no objections, I'll upload a patch to remove it for
> > review.
> >
> >
> > Yuzo
> >
> >
> >
> >
> > On Tue, Jun 15, 2010 at 5:52 PM, Yuzo Fujishima <yuzo at google.com>
> > wrote:
> >         Nikolas,
> >
> >
> >         Thank you for your response.
> >         I'll hold off
> >         committing https://bugs.webkit.org/show_bug.cgi?id=24742 until
> >         you make a decision. Please let me know when you make one.
> >
> >
> >         Yuzo
> >
> >
> >         On Tue, Jun 15, 2010 at 3:42 PM, Nikolas Zimmermann
> >         <zimmermann at physik.rwth-aachen.de> wrote:
> >
> >                 Am 15.06.2010 um 08:28 schrieb Cameron McCormack:
> >
> >
> >                         Nikolas Zimmermann:
> >                                 We had 'none' for years, until
> >                                 compatibility bugs were raised, as
> >                                 Opera uses black as default stroke, if
> >                                 there is any error.
> >
> >                         Doesn’t seem to be the case any more, at least
> >                         for Opera 10.53:
> >
> >                         http://livedom.validator.nu/?%3C!DOCTYPE%
> >                         20html%3E%0D%0A%3Csvg%20width%3D'100'%20height
> >                         %3D'100'%3E%3Ccircle%20cx%3D'50'%20cy%3D'50'%
> >                         20r%3D'30'%20fill%3D'yellow'%20stroke%3D'xxx'%
> >                         20stroke-width%3D'4'%2F%3E%3C%2Fsvg%3E
> >
> >                         Note the stroke="xxx".  Firefox nightlies
> >                         behave the same.
> >
> >
> >                 That would be good news, I've been against the switch
> >                 all time, we should reiterate that specific behaviour.
> >                 Turning off that default stroke behaviour and seeing
> >                 which layout tests break, and whether we now consider
> >                 this a progression :-)
> >                 I'll have a look at it this week.
> >
> >                 Cheers,
> >                 Niko
> >
> >
> >
> >                 _______________________________________________
> >                 webkit-dev mailing list
> >                 webkit-dev at lists.webkit.org
> >                 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >
> >
> >
> >
> >
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100908/64e5e7c3/attachment.html>