[webkit-dev] GTK Skiplist
levin at chromium.org
Fri Sep 3 10:15:05 PDT 2010
It looks like I made a comment (that I don't even remember at this point :)
) which may have triggered this.
fwiw, I try to respect how other platforms are maintaining their code
because I'd like other people to do the same even if they may think may
platform is odd. In this case, what is desired is very clearly spelled out
in the file:
I don't know why that was added because I didn't do it :). If one disagrees
with that comment, it seems like a very reasonable path to take would be to
figure out who wrote that (which isn't hard in git or svn) and* take it up
with them/the reviewer of that patch to understand if there is some reason
for this peculiarity* (and then maybe clarify the comment in some way).
On Fri, Sep 3, 2010 at 9:54 AM, Jeremy Orlow <jorlow at chromium.org> wrote:
> I promise to only put IndexedDB tests in the indexeddb directory. :-)
> On Fri, Sep 3, 2010 at 5:52 PM, Darin Adler <darin at apple.com> wrote:
>> On Sep 3, 2010, at 5:50 AM, Jeremy Orlow wrote:
>> > Recently in a code review for IndexedDB, I was told that I should be
>> adding every test individually to GTK's skip list.
>> That doesn’t sound quite right. One of the reasons the tests are grouped
>> into directories is so that things like the Skipped list can take advantage
>> of the categories created.
>> However, we don’t want to disable tests just because someone made an
>> unfortunate choice of what directory to put them in. Lets make sure that
>> doesn’t happen!
>> -- Darin
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev