[webkit-dev] GTK Skiplist

Xan Lopez xan at gnome.org
Fri Sep 3 07:20:35 PDT 2010


On Fri, Sep 3, 2010 at 9:50 PM, Jeremy Orlow <jorlow at chromium.org> wrote:
> Recently in a code review for IndexedDB, I was told that I should be adding
> every test individually to GTK's skip list.  The reason cited was this
> comment at the top "# Also, no grouping should occur. Every test for
> itself."  For features like IndexedDB which are not turned on by a port, is
> it still expected that I should be adding each and every test to the GTK
> skip list?  If so, why?  /storage/indexeddb has been in the skip list for
> some time and seems to work fine, at least from a technical standpoint.

I didn't write that, but IMHO it's perfectly OK to skip whole
directories when the reason for skipping all the tests inside is the
same or essentially the same. We already do this for storage/, for
instance.

Xan

> Thanks,
> Jeremy
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>


More information about the webkit-dev mailing list