[webkit-dev] Arena is crufty?

Kenneth Russell kbr at google.com
Thu Sep 2 09:38:43 PDT 2010


There are two cyclic data structures in the code I am adding. I would
not want to have to retrofit them with reference counting, at least
not before an initial commit so that there is a checkpoint.

-Ken

On Thu, Sep 2, 2010 at 3:15 AM, Jeremy Orlow <jorlow at chromium.org> wrote:
> Isn't ref counting supposed to be _really_ optimized for exactly this use?
>  It seems like a good match--unless you have major issues with
> cycles...which might be the issue?
> J
>
> On Thu, Sep 2, 2010 at 3:20 AM, Kenneth Russell <kbr at google.com> wrote:
>>
>> I would be happy to not add another Arena client, but the primary
>> reason I need an arena is not just for performance but to avoid having
>> to keep track of all of the objects I need to delete.
>>
>> Is there any consensus yet on how to proceed with
>> https://bugs.webkit.org/show_bug.cgi?id=45059 ? I'm concerned about
>> taking on large-scale restructuring with potential performance impact
>> as a prerequisite for my landing any initial code. I could revert my
>> PODArena class to use its own memory allocation rather than that in
>> Arena.h.
>>
>> -Ken
>>
>> On Wed, Sep 1, 2010 at 7:12 PM, David Hyatt <hyatt at apple.com> wrote:
>> > Please let's not add another client of Arena though.  That will just
>> > make it harder to remove, and I highly doubt you're getting any real
>> > performance gain from using it.
>> >
>> > dave
>> >
>> > _______________________________________________
>> > webkit-dev mailing list
>> > webkit-dev at lists.webkit.org
>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>> >
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>


More information about the webkit-dev mailing list