[webkit-dev] contribute SH4 JIT

[Holger Freyther]

On 09/02/2010 09:37 PM, thouraya andolsi wrote:
> Hello,
> 
> I would like to contribute the SH4 JIT for JavaScriptCore.
> 
> I submitted as a first step a patch containing  some changes in the build
> system to support sh4 platform for GDK/Directfb backend  to
> https://bugs.webkit.org/show_bug.cgi?id=44329.
> 
> Could you please review it  ?

Hi thouraya,

welcome to the WebKit community. Have you seen this page[1]? I have two
general remarks reagrding your bug report. You will need to set the review
flag to '?', to ask for review and you should not a reviewer. The other remark
is that we prefer one bug report per feature/thing but you have mixed
different topics (some don't even relate to JSC or JIT):

	- Disabling TCMalloc. Why is that?
	- XP_UNIX is 'used' as synonym for Unix/X11 in NPAPI, there is
          another bugreport to support NPAPI on DirectFB. You will need to
          coordinate with them
	- WebKit enum. What issue do you see? What do you attempt to patch?
	- adding inspector support to GtkLauncher.


Please create separate bug reports for these separate issues, for build fixes
explain how it broke (e.g. include a log), for NPAPI try to find the
Qt/DirectFB bug and see if Mozilla or such agreed on the API changes.


regards
	holger

[1] http://webkit.org/coding/contributing.html