[webkit-dev] FrameLoader forwarding calls to FrameLoaderClient

Nate Chapin japhet at chromium.org
Wed Sep 1 14:46:35 PDT 2010


In looking at ways to decrease the agony associated with FrameLoader,
I've noticed that there are a whole of 1-line functions on FrameLoader
that just call a similarly named function on FrameLoaderClient without
accessing any member variables other than m_client.

On the one hand, removing these forwarding functions could move a lot
of noise out of FrameLoader.  On the other hand, doing so would add
another dereference at the callsite and increase the number of places
we have to include FrameLoaderClient.h.

I'm just curious whether this was a conscious design decision
(especially since there are also a bunch of functions on
FrameLoaderClient that are called directly, rather than having a
corresponding function on FrameLoader).  Does anyone have insight into
the history of this abstraction or strong feelings on it?

~Nate


More information about the webkit-dev mailing list