[webkit-dev] Platform specific editing behaviors

[Ojan Vafai]

This matches Chromium's desired behavior and is only a change for Chromium
Linux. So, no objections there.

On Wed, Oct 27, 2010 at 2:17 PM, Antonio Gomes <tonikitoo at gmail.com> wrote:

> Hi.
>
> In bug https://bugs.webkit.org/show_bug.cgi?id=36627 (Needs a
> "LinuxEditingBehavior", perhaps with a better name) , in order to
> supply needs that the existing editing behaviors (Mac and Windows) do
> not cover, we are going to add a new editing behavior type. The name
> is not defined yet, and our current options are LinuxEditingBehavior,
> EditingUnixBehavior, EditingFreedesktopOrgBehavior,
> EditingFreedesktopBehavior or EditingXWindowsBehavior.
>
> Well, despite the naming to be used, in the same bug I am proposing
> that the editing behavior of each platform to be set according to the
> OS it is running on. As an example, Chromium when built on Mac would
> have the MacEditingBehavior set, while when built on Windows it would
> have the Window editing behavior, etc. The same logic would apply to
> all cross-platform ports, including QtWebKit. On the other hand, OS
> specific ports like Apple's Mac and Windows ports would not have to
> worry about it, since they just run on Mac or Windows respectively.
>
> static EditingBehaviorType editingBehaviorTypeForPlatform()
> {
>    return
> #if OS(DARWIN)
>    EditingMacBehavior
> #elif OS(WINDOWS)
>    EditingWindowsBehavior
> #elif OS(UNIX)
>    EditingLinuxBehavior
> #else
>    // Fallback
>    EditingMacBehavior
> #endif
>    ;
> }
>
> Before anything I would like to point it our here, and hear  from the
> port maintainers any possible objection about it, specially from the
> cross-platform ones, including Chromium and Qt.
>
> --
> --Antonio Gomes
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20101027/48906aff/attachment.html>