[webkit-dev] pixel tests and --tolerance (was Re: Pixel test experiment)

Simon Fraser simon.fraser at apple.com
Thu Oct 14 10:08:24 PDT 2010


On Oct 14, 2010, at 9:06 AM, Ojan Vafai wrote:

> Simon, are you suggesting that we should only use pixel results for ref tests?

In an ideal world, yes. But we have such a huge body of existing tests that converting them all to ref tests
is a non-starter, so I agree that we need to resolve the tolerance issue.

However, at some point I'd like to see us get to a stage where new pixel tests must be ref tests.

Simon 

> If not, then we still need to come to a conclusion on this tolerance issue.
> 
> Dirk, implementing --tolerance in NRWT isn't that hard is it? Getting rid of --tolerance will be a lot of work of making sure all the pixel results that currently pass also pass with --tolerance=0. While I would support someone doing that work, I don't think we should block moving to NRWT on it.
> 
> Ojan



More information about the webkit-dev mailing list