[webkit-dev] commit ownership and commit-queue

[Eric Seidel]

committers.py serves a different purpose that the name-rewriting on
svn.webkit.org.

committers.py is about documenting all of the committers and all of their
various email address in one place, so that our tools can understand actions
in bugzilla, scm, email lists, etc. and associate them all with the right
committer.

svn.webkit.org has some special re-writing code which uses the list of
svn-authorized usernames.

If you want svn.webkit.org to attribute commits from the commit-queue to
you, those commits need to use your svn.webkit.org username (email) in the
ChangeLog.

-eric

On Mon, Nov 29, 2010 at 9:19 AM, Antonio Gomes <tonikitoo at gmail.com> wrote:

> Hi William.
>
> I think all developers who got a @webkit.org email set up as primary
> email and for some reason switched to use a company email in the
> changelog will be affected. This is the main reason right now that
> prevents me from using the commit-queue, but if it is only me, then I
> can live with it.
>
> ps: why do many people have more than one email in committers.py then?
>
> Cheers,
>
> On Mon, Nov 29, 2010 at 1:56 AM, William Siegrist <wsiegrist at apple.com>
> wrote:
> > On Nov 28, 2010, at 10:21 PM, Antonio Gomes wrote:
> >
> >> Hi.
> >>
> >> In committers.py I have "tonikitoo at webkit" and "agomes at rim"
> >> subscribed as my working emails.
> >>
> >> ...
> >> Reviewer("Antonio Gomes", ["tonikitoo at webkit.org", "agomes at rim.com"],
> >> "tonikitoo"),
> >> ...
> >>
> >> However, when I use the commit-queue and sign the ChangeLog with the
> >> later email (agomes at rim), the commit-queue does not change the
> >> ownership to the commit to myself, i.e to my primary email (tonikitoo
> >> at webkit), although I think it shoulds. <
> >> http://trac.webkit.org/changeset/72780 > is an example of that.
> >>
> >> Would it be considered a feasible feature request?
> >>
> >
> > Is there a reason you cannot use your committer address in the changelog?
> The server currently does not use committers.py, so reengineering the author
> rewriting would take some amount of work. Is there a good reason to do this?
> >
> > -Bill
>
>
>
> --
> --Antonio Gomes
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20101129/74d410ae/attachment.html>