[webkit-dev] !ENABLE(INSPECTOR)

[Yury Semikhatsky]

I don't think there is a particular person who maintains that option.
Instead if you cannot find the change which broke it and file a bug against
the author you could file a bug against the web inspector component(
webkit.org/new-inspector-bug) and we'll take care of it.

In this particular case it was my change
http://trac.webkit.org/changeset/71515 that broke it. I didn't see the
failure because I tried to build webkit with --minimal option(and it was
fine) which is usually enough but apparently not in this case.

Yury

On Sun, Nov 14, 2010 at 2:38 AM, Patrick Gansterer <paroga at paroga.com>wrote:

> I filed bug 49500 (including patch).
>
> But I'm still interested if there is someone who "maintains" the
> ENABLE(INSPECTOR) option.
>
> Simon Fraser:
>
> > Please file a bugzilla bug on this issue.
> >
> > Simon
> >
> > On Nov 13, 2010, at 8:15 AM, Patrick Gansterer wrote:
> >
> >> Hi,
> >>
> >> Does anybody compile WebKit with inspector disabled?
> >>
> >> It's not possible with the current trunk (since weeks). I'm not sure
> what's the correct solution to fix this.
> >>
> >> The main problem is that Console.cpp (e.g. at [1]) uses ScriptCallStack
> and ScriptCallStackFrame, but this classes should go into a "#if
> ENABLE(INSPECTOR)" section IMHO.
> >> Otherwise they must not use any classes from InspectorValues (e.g. at
> [2]).
> >>
> >> Can someone fix this (or at least point me to the right solution)?
> >>
> >> [1]
> http://trac.webkit.org/browser/trunk/WebCore/page/Console.cpp?rev=71966#L171
> >> [2]
> http://trac.webkit.org/browser/trunk/WebCore/inspector/ScriptCallStack.cpp?rev=71515#L77
> >
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20101114/82c7df46/attachment.html>