[webkit-dev] webkit-patch requests

[Maciej Stachowiak]

On May 19, 2010, at 11:04 AM, Darin Adler wrote:

> On May 19, 2010, at 10:52 AM, Adam Barth wrote:
> 
>> Thanks for the feedback. Webkit-patch already respects the EDITOR environment variable. It should be a simple change to support the CHANGE_LOG_EDIT_APPLICATION environment variable also. The function that needs to change is:
>> 
>> http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system/user.py#L73
> 
> When I created the prepare-ChangeLog and commit-log-editor scripts 8 years ago I did the following:
> 
>    - Had a separate CVS_LOG_EDITOR (later SVN_LOG_EDITOR) environment variable in case someone wanted a different editor for this purpose than the general case.
> 
>    - Added CHANGE_LOG_EDIT_APPLICATION to adapt the work flow better to a Mac OS X application where you would not quit after editing the files. But I had to come up with a different way to indicate “I’m done” in such cases. Probably could do something similar to what we do after launching Safari to browse the diff.
> 
> There’s also a tool called xed that I could probably use as an EDITOR. The xed command has an option "--wait" that can make it behave more like modal vi. The xed tool was created many years after I wrote those scripts.

The Mac OS X "open" command also has a -W option which can wait for quit.

I believe setting EDITOR="open -W -a Xcode" would probably do it.

Regards,
Maciej