[webkit-dev] Python on the Tiger build bot

[Fumitoshi Ukai (鵜飼文敏)]

I heard on #webkit that the Tiger bot has been on Python 2.5 for some time,
and found r+ for https://bugs.webkit.org/show_bug.cgi?id=38886 and
https://bugs.webkit.org/show_bug.cgi?id=38822. I believe we have consensus
to use Python 2.5 (or later) for webkit development environment.

I tried to land autoinstalled pywebsocket 0.5
https://bugs.webkit.org/show_bug.cgi?id=38034 again, but get error on tiger
bot when launching websocket server as below.
Is python on the tiger bot still 2.3?
I'm wondering why the script raises SyntaxError at with-statement, although
it uses "from __future__ import with_statement" at the beginning of the same
file.
Doesn't python raise error when it tries to import with_statement, rather
than it sees with statement later?

Anyway, I just marked to skip websocket/tests on tiger for now, hoping
python2.5 is available on tiger bot soon.

This is log:
http://build.webkit.org/builders/Tiger%20Intel%20Release/builds/11971/steps/layout-test/logs/stdio
websocket/tests .Traceback (most recent call last):
  File "WebKitTools/Scripts/new-run-webkit-websocketserver", line 38, in ?
    import webkitpy.layout_tests.port.websocket_server as websocket_server
  File
"/Volumes/Data/WebKit-BuildSlave/tiger-intel-release/build/WebKitTools/Scripts/webkitpy/layout_tests/port/websocket_server.py",
line 241
    with codecs.open(self._pidfile, "w", "ascii") as file:
              ^
SyntaxError: invalid syntax

websocket/tests/bad-handshake-crash.html -> failed
.
websocket/tests/bad-sub-protocol-control-chars.html -> failed
.
websocket/tests/bad-sub-protocol-empty.html -> failed
.
websocket/tests/bad-sub-protocol-non-ascii.html -> failed
.
websocket/tests/bufferedAmount-after-close.html -> failed
.
websocket/tests/close-on-navigate-new-location.html -> failed
.
websocket/tests/close-on-unload-and-force-gc.html -> failed
.
websocket/tests/close-on-unload-reference-in-parent.html -> failed
.
websocket/tests/close-on-unload.html -> failed
.
websocket/tests/cross-origin.html -> failed
.
websocket/tests/error-detect.html -> failed
.
websocket/tests/frame-length-longer-than-buffer.html -> failed
.
websocket/tests/frame-length-skip.html -> failed
.
websocket/tests/frame-lengths.html -> failed
.
websocket/tests/handshake-error.html -> failed
.
websocket/tests/handshake-fail-by-cross-origin.html -> failed
.
websocket/tests/handshake-fail-by-sub-protocol-mismatch.html -> failed
.
websocket/tests/httponly-cookie.pl -> failed
.
websocket/tests/long-invalid-header.html -> failed
.
websocket/tests/multiple-connections.html -> failed

Exiting early after 20 failures. 17934 tests run.
762.46s total testing time
Traceback (most recent call last):
  File "WebKitTools/Scripts/new-run-webkit-websocketserver", line 38, in ?
    import webkitpy.layout_tests.port.websocket_server as websocket_server
  File
"/Volumes/Data/WebKit-BuildSlave/tiger-intel-release/build/WebKitTools/Scripts/webkitpy/layout_tests/port/websocket_server.py",
line 241
    with codecs.open(self._pidfile, "w", "ascii") as file:
              ^
SyntaxError: invalid syntax

--
ukai

On Tue, May 11, 2010 at 15:07, Maciej Stachowiak <mjs at apple.com> wrote:

>
> On May 10, 2010, at 11:01 PM, Eric Seidel wrote:
>
>  On Mon, May 10, 2010 at 2:25 AM, Maciej Stachowiak <mjs at apple.com> wrote:
>>
>>> My feeling about requiring a higher Python version for Tiger remains
>>> this:
>>>
>>> "I'd prefer that we provide an easy means to do the install of Python 2.6
>>> (ideally a single script you can run, and ideally without affecting the
>>> system copy), rather than making every Tiger developer figure it out on
>>> their own."
>>> http://www.mail-archive.com/webkit-dev@lists.webkit.org/msg10331.html
>>>
>>> For those of us who still need to support Tiger, it would be a huge
>>> hassle
>>> to have to figure out how to update Python manually to even run the
>>> layout
>>> tests. The fact that it's not a primary development platform doesn't mean
>>> that it's ok to add stumbling blocks to the development process. In fact,
>>> it
>>> kinda makes it less ok, because then it takes more work to shift gears
>>> when
>>> fixing a Tiger-specific bug.
>>>
>>
>> Provided:
>> https://bugs.webkit.org/show_bug.cgi?id=38886
>>
>>  At minimum, there should be instructions here, and ideally the install
>>> should be one step:
>>> http://webkit.org/building/tools.html
>>>
>>
>> Provided:
>> https://bugs.webkit.org/show_bug.cgi?id=38822
>>
>
> Yay thanks! (Will try to review these later if no one beats me.)
>
> Regards,
> Maciej
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100513/55e60123/attachment.html>