[webkit-dev] Help with reviewing Spatial Navigation patches

tonikitoo (Antonio Gomes) tonikitoo at gmail.com
Wed May 5 09:12:19 PDT 2010


As part of my (spare-time) effort to keep developing the Spatial
Navigation [1], I've been getting great reviewing support from Simon
Fraser and Kenneth Christiansen, but lately the number of pending
review patches increased a bit. There are on my plate patches from
polishment work to real bug fixes and feature completeness. So there
some very easy patches to review, like:

-polishment work:
* bug 38584 - Spatial Navigation: use data url in layout
* bug 38488 - Spatial Navigation: create a getter for the "fudgeFactor"
* bug 37633 - Spatial Navigation: use a static var in maxDistance
method ( SpatialNavigation.h ) <-- one liner!

- improvements on the feature test covarege:
* bug 38585 - Spatial Navigation: add a layout test which runs with
Frame Flattening ON

- preparation for feature implementation:
* bug 37803 - Spatial Navigation: adapt the logic of
{deep}findFocusableNodeInDirection to do traversal starting from Node*
not Document*
For this one I even added a comment in the bug with a detailed
explaination about the changes [2], so a reviewer does not need to
know the feature code in deep to review it.
* Spatial Navigation: refactor hasOffscreenRect to work with
scrollable content <-- has a patch , but not set r? because it depends
on bug 36463, which depends on 37803.

... as well as not so trivial patches to be reviewed:

- feature implementation:
* bug 36463 -  Spatial Navigation: make it work with focusable
elements in overflow content <-- depends on the former preparation bug
* bug 37153 -  Spatial Navigation: add support to <input type=text>
and <textarea> <-- has a patch, but needs polishment to request

Reviewers, could you please help with that?

Thank you in advance

[1] https://bugs.webkit.org/showdependencytree.cgi?id=18662&hide_resolved=0
[2] https://bugs.webkit.org/show_bug.cgi?id=37803#c5

--Antonio Gomes

More information about the webkit-dev mailing list