[webkit-dev] Help with review of EFL CMake patches?

Adam Treat treat at kde.org
Mon May 3 12:23:11 PDT 2010


Bill, could you look over these CMake files and give it an informal review?

On Monday 03 May 2010 02:37:22 pm Gustavo Sverzut Barbieri wrote:
> Hi all,
> 
> As some of you know, the EFL port is almost all merged, we just lack a
> build system in SVN by now. We initially started with automake,
> sharing with GTK, but it was quite slow and the Gtk guys had the
> willing to get it clean before any changes were made, in order to
> avoid it to get worse. We did an initial cleanup, but then we figured
> out CMake would be a better option.
> 
> By the time we were almost done with CMake build system, this mail
> list started discussing build systems and CMake was one of the
> considered options, making us quite happy at the time.
> 
> We got the system done, but then people just started to move files in
> SVN making our lives quite hard these last weeks. Fortunately things
> are calm now and the system compiles quite well. We did the patches
> splitting the common and EFL specific parts, so people may add new
> ports with minimum effort. Of course as more systems are added, we
> should rearrange things that we overlooked at first, but that should
> be easy.
> 
> What we need know is someone to review
> https://bugs.webkit.org/show_bug.cgi?id=37945 and land it to SVN.
> 
> Note that we're trying to get EFL to build with SVN, not to build the
> most perfect CMake build system ever. So let's be reasonable with
> comments and suggestions, particularly those to make it "generic" as
> we consider that these should come when people start moving their
> ports to CMake. We surely can help with such tasks, we have a
> partially working GTK port that we may finish one day and suggest to
> webkit-gtk the move to it.
> 
> BR,


More information about the webkit-dev mailing list