[webkit-dev] [webkit-changes] [56825] trunk

[Gavin Barraclough]

On Mar 31, 2010, at 10:08 AM, Alexey Proskuryakov wrote:

> On 30.03.2010, at 22:44, barraclough at apple.com wrote:
>
>> +WebCString::operator WTF::CString() const
>
> There probably should be a "using CString" directive in CString.h -  
> we do that for all public symbols in WTF.

There should be ... http://trac.webkit.org/browser/trunk/JavaScriptCore/wtf/text/CString.h?rev=56825#L79 
  ... and there already is!

> The idea is that we don't need or want namespaces to avoid name  
> conflicts between public WTF symbols and WebCore or WebKit, as we  
> control them all.

There are two problems that currently cause name conflicts for the  
name CString in ToT.   One is that JSC currently defines a class  
called CString (when I land https://bugs.webkit.org/show_bug.cgi?id=36871 
  this will go away), so in .cpp files that do a "using namespace JSC"  
the name CString is ambiguous.  Secondly, Windows has a standard type  
called CString in its libraries, which appears to conflict when  
compiling some files.  Additionally, when changing some files  
exclusively used in ports that I don't build locally I chose to be  
conservative & reduce this risk of setting the tree on fire by just  
replacing WebCore::CString with WTF::CString while landing this patch.

Once JSC::CString has gone away I'll have a look through at some point  
& see if some of the remaining WTF::s are redundant and can be removed.

cheers,
G.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100331/eb67929c/attachment.html>