[webkit-dev] Determining platform in LayoutTests

Ojan Vafai ojan at chromium.org
Mon Mar 29 08:44:38 PDT 2010


On Sun, Mar 28, 2010 at 8:58 PM, Alexey Proskuryakov <ap at webkit.org> wrote:
>
> 28.03.2010, в 19:26, Sam Weinig написал(а):
> > One alternative, where applicable, is to make the behavior a runtime
> setting, and thus enable testing it on all platforms. Performance could get
> in the way of this.
>
> That's how we've been doing it for some selection-related tests, and that's
> definitely the best approach as far as testing is concerned. This way, all
> code paths get tested on all platforms.
>

There's a FIXME in the handful of tests that do this to expose the
editingBehavior setting and use that instead. That's clearly the right
solution in this case.

Ojan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100329/8a00de63/attachment.html>


More information about the webkit-dev mailing list