[webkit-dev] upgrading sqlite library

Dumitru Daniliuc dumi at chromium.org
Fri Mar 26 17:20:15 PDT 2010


my test still fails in safari/DRT. according to richard hipp, the patch that
fixed this problem (http://www.sqlite.org/src/ci/256ec3c6af) was added to
sqlite starting with version 3.6.16 (chromium uses 3.6.18, that's why the
test passed there). i couldn't patch webkit's sqlite library, but i changed
some webkit code to essentially do the same thing that the patch does and my
test does pass in DRT/safari now. i will add my work-around to webkit, but
it might be worth upgrading the library used by webkit and safari (and other
ports should probably do the same) to a newer sqlite version.

dumi


On Fri, Mar 26, 2010 at 4:42 PM, Sam Weinig <sam.weinig at gmail.com> wrote:

> In fairness to Mark Rowe, he did the work.
>
> On Fri, Mar 26, 2010 at 12:32 PM, Dumitru Daniliuc <dumi at chromium.org>wrote:
>
>> it's a new test that i haven't submitted yet.
>>
>> sam: thanks for upgrading sqlite. i'm running that test right now.
>>
>> dumi
>>
>>
>>
>> On Fri, Mar 26, 2010 at 9:43 AM, Brady Eidson <beidson at apple.com> wrote:
>>
>>>
>>> On Mar 25, 2010, at 5:34 PM, Dumitru Daniliuc wrote:
>>>
>>> >  (a HTML5 DB test fails 100% of the time in safari and DRT, but passes
>>> 100% of the time in chromium and as a standalone program linked directly to
>>> sqlite 3.4.2)
>>>
>>> What is the bugzilla for this?  A test that should pass but fails 100% of
>>> the time in mainline WebKit is something we should be tracking to fix.
>>>
>>> ~Brady
>>>
>>>
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100326/dcf8ff09/attachment.html>


More information about the webkit-dev mailing list