[webkit-dev] best practice for failing Windows tests?

Ojan Vafai ojan at chromium.org
Mon Mar 15 12:27:52 PDT 2010


On Mon, Mar 15, 2010 at 12:24 PM, Alexey Proskuryakov <ap at webkit.org> wrote:

> On 15.03.2010, at 12:11, Ojan Vafai wrote:
>
>> 1. Rollback r55913. This seems silly since it's just exposing an existing
>> bug.
>> 2. Update the windows expected results and file a bug.
>> 3. Skip the tests on Windows.
>>
>
> There is also
> 4. Change the tests so that they don't trigger the bug (click at a
> different location?), and file a bug report.


Hah, I was just writing an update with this option. :)

I agree, 4 is best. I'll post a patch once I finally get Windows building
again.

Ojan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100315/f4f6a045/attachment.html>


More information about the webkit-dev mailing list