[webkit-dev] WebCore Build Times

[Eric Seidel]

I've made one attempt at this with
https://bugs.webkit.org/show_bug.cgi?id=40350

It seems accessibility, javascriptcore and svg are the worst over-includers.

There are also a bunch of core element/node methods which are inline and
bring in a long list of header dependencies. We should consider creating a
new ElementInlines.h at some point, then only files which actually need the
inlines could include those.

On Jun 8, 2010 4:19 PM, "Eric Seidel" <eric at webkit.org> wrote:
> I think were I to try attacking this, I would write a script to
> generate a list of includes, and the number of cpp files which include
> them.
>
> Then I would work from the most-included end of that list, trying to
> reduce the number of files include each include.
>
> -eric
>
> On Tue, Jun 8, 2010 at 4:04 PM, David Kilzer <ddkilzer at webkit.org> wrote:
>> On Jun 8, 2010, at 3:17 PM, Eric Seidel <eric at webkit.org> wrote:
>>
>>> On my Intel Core 2 Duo MBP a full build takes over 1 hour.  5 years
>>> ago, on my g4 laptop a full build took around 40m.  :(  We seem to be
>>> slowly moving in the wrong direction.
>>
>> Was that before or after SVG was enabled in the engine?  :)  In general,
I think the amount of code in WebCore has increased since 2005, which
probably has more of an affect than unused headers.
>>
>> Having said that, I thought it would be useful to write a script that
would remove individual headers on a file-by-file basis and recompile WebKit
to find unused header candidates.  I haven't had time to write such a
script, though.
>>
>> Dave
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100609/7ab8a7ce/attachment.html>