[webkit-dev] Patches saying “Unreviewed”
eric at webkit.org
Fri Jul 30 16:03:01 PDT 2010
Last time I did that, I was accused of shouting... :)
But I support making prepare-ChangeLog less confusing. Our "fix up
one of the OOPS, but don't touch the other!" expectation of
contributors is the source of much confusion. :)
On Fri, Jul 30, 2010 at 6:57 PM, Darin Adler <darin at apple.com> wrote:
> It’s totally reasonable for the bot to require a reviewer line, because the bot requires a reviewer on the bug too.
> It’s in non-bot contexts that I think it’s not good. I think that means I agree with you both who said that running webkit-patch on the command line shouldn't require it. We can have the commit bot use an option to tell webkit-patch it wants that rule.
> As far as the confusion factor is concerned, we could change the wording of the "Reviewed by" line added by prepare-ChangeLog to make it more explicit.
> Reviewed by <REVIEWER-NAME-WILL-BE-FILLED-IN-HERE-DO-NOT-DELETE> (OOPS).
> Or something nicer than that but with a similar flavor.
> -- Darin
More information about the webkit-dev