[webkit-dev] review queue crazy idea

Peter Kasting pkasting at google.com
Wed Jul 21 14:45:27 PDT 2010


On Wed, Jul 21, 2010 at 2:40 PM, Ojan Vafai <ojan at chromium.org> wrote:

> Here are my initial thoughts on what a review bot would do.
>
> *After a patch turns a week old, send the following email:*
> Patch 12345 of bug 6789 is a week old. It may just be because no reviewer
> has found time to review it. But there may be steps you can take to help get
> your patch reviewed. See http://trac.webkit.org/wiki/CodeReview for a few
> suggestions.
>
> -WebKit review bot
>
> *After the patch is three weeks old:*
> Patch 12345 of bug 6789 is three weeks old. If it is still unreviewed in a
> week, it will automatically be rejected. It may just be because no reviewer
> has found time to review it. But there may be steps you can take to help get
> your patch reviewed. See http://trac.webkit.org/wiki/CodeReview for a few
> suggestions.
>
> -WebKit review bot
>
> *After the patch is a month old:*
> Patch 12345 of bug 6789 has been rejected because it is too old. This is
> likely because no webkit reviewer has been able to review it. If you would
> still like the patch reviewed, then please do the following:
>
>    1. Make sure your patch still applies to tip of tree.
>    2. Do as many of the suggestions at
>    http://trac.webkit.org/wiki/CodeReview as possible.
>    3. Upload your patch for review again.
>
> If we want to implement this, I think there ought to be some sort of easy
way for a patch author to respond to any of these automated actions with
some kind of a "I looked at the suggestions, my patch is as easy-to-review
as possible, please don't close it and instead help me flag down some
reviewers" action.

PK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100721/1f25e283/attachment.html>


More information about the webkit-dev mailing list