[webkit-dev] Frustrated at inconsiderate behavior
mjs at apple.com
Wed Jul 7 01:54:37 PDT 2010
Thank you for fixing the problem.
Did you try talking to Alexey directly about this? Or to someone else who may be familiar with the situation? It's usually better to try steps like that before calling someone out on the mailing list. And if you do need to bring something to wider attention, perhaps you could consider a less strident tone. In the WebKit project, we prefer to resolve disputes calmly and respectfully, especially among longtime valued contributors such as Alexey and yourself. I realize that at times, contributors can feel frustrated, but let's try to keep the project mailing list a happy place.
On Jul 7, 2010, at 12:47 AM, Adam Barth wrote:
> If you're tired of my complaining about the tree being red, you can
> skip this message.
> Today Alexey checked in <http://trac.webkit.org/changeset/62576>,
> which broke two tests on every port. 12 hours later, these failures
> remained in the tree until I cleaned them up. This mess could have
> been avoided in a number of ways:
> 1) He could have run-webkit-tests before committing his change.
> 2) If he didn't have time to run the tests locally, he could have used
> the commit-queue to run-webkit-tests before it landed his patch.
> 3) He could have looked at the tree when sheriff-bot informed him that
> he might have broken Leopard Intel Debug by pinging him in #webkit and
> commenting on his bug:
> Is this acceptable behavior?
> http://webkit.org/coding/contributing.html clearly says to "run the
> layout tests using the run-webkit-tests script and make sure they all
> pass." That page also says:
> In either case, your responsibility for the patch does not end with
> the patch landing in the tree. There may be regressions from your
> change or additional feedback from reviewers after the patch has
> landed. You can watch the tree at build.webkit.org to make sure your
> patch builds and passes tests on all platforms. It is your
> responsibility to be available should regressions arise and to respond
> to additional feedback that happens after a check-in.
> Are there consequences for breaking these rules?
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
More information about the webkit-dev