[webkit-dev] location in the tree for third party python code?

[Eric Seidel]

Be aware, there are a couple known issues with our current autoinstall setup:
https://bugs.webkit.org/show_bug.cgi?id=33632
https://bugs.webkit.org/show_bug.cgi?id=33365

On Thu, Jan 21, 2010 at 2:35 PM, Adam Barth <abarth at webkit.org> wrote:
> This page makes it looks like we can just autoinstall simplejson:
>
> http://pypi.python.org/pypi/simplejson/
>
> IMHO, that's better than checking it in.
>
> Adam
>
>
> On Thu, Jan 21, 2010 at 1:58 PM, Eric Seidel <eric at webkit.org> wrote:
>> We also have webkitpy/autoinstall.py which knows how to download
>> modules on-demand.  This is useful in the case that you're using code
>> with an incompatible license.
>>
>> see webkitpy/__init__.py for an example of how we pull in mechanize
>> (which is a HUGE module, with a compatible license for most files, but
>> includes a bit of code which is not compatible).
>>
>> On Thu, Jan 21, 2010 at 1:39 PM, David Levin <levin at google.com> wrote:
>>> So far, things have been put in place with other files (like the python
>>> websockets code) but I think that is confusing for a number of reasons:
>>> 1. The level of review needed varies imo between 3rd party code that is
>>> being used vs new code added to wk.
>>> 2. The style never seems to match what is done for the rest of WebKit.
>>> 3. It becomes unclear how to update it because there aren't always good
>>> concise instructions about this.
>>> Personally, I'd much prefer a ThirdParty directory to check these things
>>> into which we could use to help address these things.
>>> dave
>>>
>>> On Thu, Jan 21, 2010 at 1:30 PM, Dirk Pranke <dpranke at chromium.org> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> I'm about to upload a patch that depends on third-party python code
>>>> (simplejson). The patch is a bunch of scripts that'll live under
>>>> WebKitTools/Scripts . Is there an appropriate place for the simplejson
>>>> code? In the absence of a better location, I'll probably check it in
>>>> under WebKitTools.
>>>>
>>>> -- Dirk
>>>> _______________________________________________
>>>> webkit-dev mailing list
>>>> webkit-dev at lists.webkit.org
>>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>