[webkit-dev] Tagging bug names with a platform name: limit to platform-specific patches

Chang.Shu at nokia.com Chang.Shu at nokia.com
Thu Jan 21 13:58:58 PST 2010


Just want to add my two cents.
Based on my own experience, I think a patch that targets to fix a platform-specific problem but ends up making changes in platform-independent code, often means either the fix is problematic or a new bug/test case needs to be created for the independent part only.

Chang

-----Original Message-----
From: webkit-dev-bounces at lists.webkit.org [mailto:webkit-dev-bounces at lists.webkit.org] On Behalf Of ext Darin Adler
Sent: Wednesday, January 20, 2010 11:19 AM
To: WebKit Development
Subject: [webkit-dev] Tagging bug names with a platform name: limit to platform-specific patches

Hi folks.

We've never formalized this, but I believe that patches tagged with a particular platform name such as

     [Qt] Add new API for fluffy bunnies

should be limited to one particular platform's code. If the patch changes more than a trivial bit of platform-independent code, even if the change is only for the benefit of a signle platform, I suggest we not use the platform name prefix.

    -- Darin

_______________________________________________
webkit-dev mailing list
webkit-dev at lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


More information about the webkit-dev mailing list