[webkit-dev] #endif // Foo_h

David Levin levin at google.com
Mon Jan 4 16:00:52 PST 2010

These seemed to be common in WebKit code, so I had it in
Sorry for letting this one linger for so long. It is in my queue just
low on the priority list).

Here's the relevant part:

#if(def) statements
If an #if(def) spans more than a few lines, end it like this:
  #endif // WhateverWasInTheIf

Like with many of these style issues, I don't care either way about this
issue but was simply trying to note what seemed to be commonly done, so I'm
fine with not having this.


PS I'll bump on the priority on translating that email into the style guide.
(I'll try to do it this week.)

On Mon, Jan 4, 2010 at 3:41 PM, Darin Adler <darin at apple.com> wrote:

> On Jan 4, 2010, at 3:33 PM, Darin Fisher wrote:
> > I noticed recently that the style bot started complaining about header
> files ending with "#endif" instead of "#endif // Foo_h".  I was surprised by
> this since the style guide does not require it.
> I personally see little value in this sort of comment at the end of a
> header file. I’m not sure what kind of problem it’s supposed to prevent.
>    -- Darin
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100104/f6ede63e/attachment.html>

More information about the webkit-dev mailing list