[webkit-dev] Commit queue blocked because of failing tests

[Eric Seidel]

That test is kinda tricky.  The change isn't necessarily wrong.  But
the patch appears to have changed what the DOM tree looks like (at
least in order) and thus exposed bugs in our JS bindings where some
objects aren't being created with the proper prototype chains.

Our JS bindings get cached after first access, so the order in which
they're accessed can change what code path is used to create them and
expose bugs like this where PASS messages turn into FAILs because the
binding was not created with the right global object pointer.

On Wed, Feb 24, 2010 at 3:50 PM, Eric Seidel <eric at webkit.org> wrote:
> I find http://build.webkit.org/console more useful.
>
> In this case, looks like mitz's patch changed the test:
> http://trac.webkit.org/changeset/55203
>
> I'm glad to see more folks are watching the bots!
>
> -eric
>
> On Wed, Feb 24, 2010 at 3:48 PM, David Levin <levin at chromium.org> wrote:
>> 1. It looks like you are a committer, so you don't need to wait for the
>> commit queue to do this for you :)
>> 2. But it still would be good to have this fixed. If you'd like to help move
>> this along, you can go to http://build.webkit.org/waterfall and find which
>> patch caused the test to start failing. Then ping the relevant person.
>>
>> On Wed, Feb 24, 2010 at 3:41 PM, Kenneth Russell <kbr at google.com> wrote:
>>>
>>> On Wed, Feb 24, 2010 at 12:02 PM, Alexey Proskuryakov <ap at webkit.org>
>>> wrote:
>>> >
>>> > On 24.02.2010, at 11:47, David Levin wrote:
>>> >
>>> > Actually, it doesn't appear to be do to recent changes in this
>>> > area. They
>>> > started failing after r55177
>>> > (http://build.webkit.org/waterfall?last_time=1266975298), but that
>>> > change is
>>> > unrelated to these test as far as I can tell.
>>> >
>>> > It looks unrelated, but it somehow broke these editing tests
>>> > nonetheless.
>>> > I'm investigating now.
>>>
>>> Thanks. Our patch (from https://bugs.webkit.org/show_bug.cgi?id=34459)
>>> was about to be landed by the bot when the tree went red again. The
>>> test now failing is:
>>>
>>> fast/dom/prototype-inheritance-2.html -> failed
>>>
>>> Could someone please look?
>>>
>>> Thanks,
>>>
>>> -Ken
>>
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>