[webkit-dev] Plan to move TypedArray out of WebGL feature guard

[Jian Li]

Currently the definition of TypedArray is guarded by ENABLE(3D_CANVAS) ||
ENABLE(BLOB). It has been used in the following features:

   - WebGL
   - File API: FileReader and BlobBuilder
   - XMLHttpRequest: send and response

We do not add an additional check expression when TypedArray is added to
XHR. We should do that but it will incur updating lots of files. If
TypedArray is used in another conditional feature, we will have to repeat
the same update.

I think it would be better if we could use a single guard or remove the
guard.


On Thu, Dec 23, 2010 at 11:01 AM, Darin Adler <darin at apple.com> wrote:

> Yes, we want correct conditionals, and TypedArray should not be in the
> WebGL feature guard if it’s used in other features.
>
> Adding a feature new guard would not be good if it has to be set
> explicitly. It would be much better if the build just decided correctly
> based on the other feature guards.
>
> If TypedArray is used in multiple conditional features, then we have to use
> the correct expression to check the feature guards.
>
> If it’s used in any unconditional feature, then it should not have a
> feature guard at all.
>
>    -- Darin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20101223/e9ab2bfb/attachment.html>