[webkit-dev] We need OwnPtrHashMap

Maciej Stachowiak mjs at apple.com
Mon Aug 30 09:22:48 PDT 2010


On Aug 29, 2010, at 9:34 PM, Maciej Stachowiak wrote:

> 
> On Aug 29, 2010, at 9:14 PM, Maciej Stachowiak wrote:
> 
>> Yet another possibility is to use a hash to do the de-duping instead of sorting; I can't tell from context if the sorting is needed for any purpose other than subsequent de-duping.
> 
> Turns out this doesn't work - the CSS Media Queries spec specifically requires serializing in sorted order and we have a test to that effect:
> http://dev.w3.org/csswg/cssom/#serializing-media-queries
> https://bugs.webkit.org/show_bug.cgi?id=39220
> 
> So it's down to violating the type system or writing my own sort.

OK, you silently guilted me into writing a non-copying sort function.

<https://bugs.webkit.org/show_bug.cgi?id=44874>

 - Maciej



More information about the webkit-dev mailing list