[webkit-dev] js binding: function argument type checking

Darin Fisher darin at chromium.org
Wed Aug 11 22:58:23 PDT 2010

On Wed, Aug 11, 2010 at 10:37 PM, Sam Weinig <sam.weinig at gmail.com> wrote:

> On Wed, Aug 11, 2010 at 10:29 PM, Cedric Vivier <cedricv at neonux.com>wrote:
>> On Thu, Aug 12, 2010 at 13:26, Sam Weinig <sam.weinig at gmail.com> wrote:
>>> For this specific case, it seems like you could easily check for a null
>>> WebGLProgram* in WebGLRenderingContext::useProgram and set the
>>> ExceptionCode.
>> Nope, null is a valid argument, it bounds to the initial program, which
>> means nothing will be drawn with WebGL.
>> Certainly not the expected behavior when one pass the wrong type to the
>> argument like Zhenyao pointed out, therefore throwing TypeError really makes
>> sense here (and elsewhere with WebGL API).
> Ok, in that case, it seems like you need to do it in the bindings for this.
> I would prefer not making a sweeping change at this time, and instead
> keeping the changes just to places where the extra checking is necessary due
> to ambiguity (as in this useProgram case).
> -Sam
Out of curiosity, if we have the ability for code to be auto generated from
the IDL, why not use it universally?  I'm trying to guess to understand your
preference :)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100811/9891b27e/attachment.html>

More information about the webkit-dev mailing list