[webkit-dev] Why are we running Sputnik?

[Evan Martin]

Given Maciej's and Adam's comments about these tests helping find
non-JS-engine-specific regressions, why not always run them?

On Wed, Aug 11, 2010 at 11:09 AM, Mads Sig Ager <ager at chromium.org> wrote:
> The V8 buildbots are running the sputnik tests and they do catch
> regressions for us. In the V8 repository we have a list of V8 test
> expectations for the sputnik tests.
>
> http://build.chromium.org/buildbot/v8/waterfall
>
> -- Mads
>
> On Wed, Aug 11, 2010 at 7:32 PM, Ojan Vafai <ojan at chromium.org> wrote:
>> Just looking at the history, it looks like when the tests were originally
>> checked in, they had no expected results. So someone on the chromium team
>> skipped them all. There's a comment in
>> http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium/test_expectations.txt
>> that "we probably don't want to run these", but I think that comment is just
>> wrong.
>> On Wed, Aug 11, 2010 at 9:31 AM, Eric Seidel <eric at webkit.org> wrote:
>>>
>>> If these tests are actually valuable, then maybe my question then
>>> belongs: Why is Chromium no longer running these tests?  (Assuming my
>>> source is correct.)
>>>
>>> -eric
>>>
>>> On Wed, Aug 11, 2010 at 7:10 AM, Maciej Stachowiak <mjs at apple.com> wrote:
>>> >
>>> > On Aug 10, 2010, at 2:26 PM, Alexey Proskuryakov wrote:
>>> >
>>> >>
>>> >> 10.08.2010, в 14:00, Adam Barth написал(а):
>>> >>
>>> >>> A better long-term fix might be to finish new-run-webkit-tests so we
>>> >>> can run the tests in parallel.
>>> >>
>>> >>
>>> >> One reason to move the tests to run-javascriptcore-tests is that people
>>> >> working on JS run these more often (sometimes not even building WebCore
>>> >> until ready to submit a patch).
>>> >
>>> > If these tests can catch regressions from non-JS-engine changes (and
>>> > according to Adam's message, they have done so at least once), then we need
>>> > to run them in the full browser engine context, even if we also have a
>>> > version that runs in a JS-only command-line tool.
>>> >
>>> > As another data point, some of the Sputnik tests are currently failing
>>> > in WebKit2 on Mac, so they are detecting a problem that they wouldn't be
>>> > able to if they ran JS-only.
>>> >
>>> > Regards,
>>> > Maciej
>>> >
>>> > _______________________________________________
>>> > webkit-dev mailing list
>>> > webkit-dev at lists.webkit.org
>>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>> >
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>