[webkit-dev] Trouble reviewing patches since the experimental commenting support went into bugs.webkit.org's action=review page
abarth at webkit.org
Thu Apr 22 13:41:39 PDT 2010
On Thu, Apr 22, 2010 at 1:15 PM, Maciej Stachowiak <mjs at apple.com> wrote:
> Seems like the most critical issue is that old-style review is broken.
> Perhaps the comment field can be cleared with a button, or we could add a
> button to paste the full patch. Other issues seem like iterative refinements
> we could do over time.
> - Maciej
> On Apr 22, 2010, at 1:09 PM, Adam Barth <abarth at webkit.org> wrote:
>> How would you like me to address this issue?
>> On Thu, Apr 22, 2010 at 1:01 PM, Darin Adler <darin at apple.com> wrote:
>>> I’m having trouble reviewing patches with the action=review patch since
>>> the experimental commenting support was added. I now have to do a lot of
>>> editing and copying and pasting when reviewing that was not necessary
>>> I can't cite things by hand. Before I would never need to copy and paste
>>> when reviewing, just delete things, but now if I do want to cite more than
>>> one line I need to open another window.
>>> - The comments all cite only a single line of the patch and I almost
>>> never have a comment that's for a single line. So I have to do a lot of
>>> editing, pretending to comment on multiple lines.
>>> patch, and then the script code deletes it. Inelegant, and easy to fix!)
>>> -- Darin
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
More information about the webkit-dev