[webkit-dev] Experimental new code reviews

[Adam Barth]

+scherkus

On Mon, Apr 19, 2010 at 4:01 PM, Maciej Stachowiak <mjs at apple.com> wrote:
>
> I heard another group coded up a different approach to improving reviews -
> does anyone have a URL for that, so we can compare?
> Cheers,
> Maciej
>
> On Apr 19, 2010, at 3:35 PM, Ojan Vafai wrote:
>
> At the hackathon last Tuesday, a few of us put together mashup style
> rietveld integration with bugs.webkit.org. It currently requires a chrome
> extension. We'll integrate properly with bugzilla based on feedback if this
> seems to be a value add for the project.
> http://webkit-rietveld.googlecode.com/svn/trunk/chrome-extension/webkit-cr.crx
> You can try it out on the *last* attachment
> on https://bugs.webkit.org/show_bug.cgi?id=37531.
> You'll see another link next to each attachment labelled "Fancy Review".
> This loads a page much like the current review page, but
> with wkrietveld.appspot.com in the top frame (wkrietveld is our fork of
> rietveld). You can then make comments in rietveld. When you click the submit
> button, the comments are published *both* in Reitveld and
> to bugs.webkit.org.
> We do not intend to remove the old code review system for people who prefer
> to stick to that.
>
> Known issues:
> -Currently, only works with patches that are uploaded using "webkit-patch
> upload --fancy-review".
> -Due to using a chrome extension rather than a tighter integration, some
> things are a bit janky (e.g. the initial load).
> -Each time a patch is uploaded, it currently creates a new rietveld issue.
> Ojan _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>