[webkit-dev] Qt is now a "core builder"

Ojan Vafai ojan at chromium.org
Thu Apr 15 08:59:02 PDT 2010


omg. The green (and orange) is blinding me:
build.webkit.org/waterfall?category=core.

Bill, I tend to rely on seeing the changes in the change column. It's not
the end of the world, but if it's not too hard to do, I'd appreciate
changing the svn hooks.

Ojan

On Thu, Apr 15, 2010 at 6:49 AM, William Siegrist <wsiegrist at apple.com>wrote:

> One thing I noticed is that the Core-only waterfall does not show any
> changes in the change column (because we're not sending them with any
> specific category). If that bothers anyone, I can change the svn hooks. The
> console does not have this problem.
>
> -Bill
>
>
> On Apr 15, 2010, at 6:22 AM, William Siegrist wrote:
>
> > The master has been reconfigured. Now there are two links, Core Console
> and Core Waterfall on the main page which will show just the core builders.
> The regular Console view also separates the builders by category, but will
> show all of them.
> >
> > -Bill
> >
> >
> >
> > On Apr 14, 2010, at 9:17 AM, William Siegrist wrote:
> >
> >> I was thinking of something like the following, assuming we want to have
> core builders still. The URL to see only core builders would be:
> >>
> >> http://build.webkit.org/console?category=core
> >> http://build.webkit.org/waterfall?category=core
> >>
> >> ... and we could use redirects or just add new links to the main page.
> >>
> >>
> >>
> >> Index: master.cfg
> >> ===================================================================
> >> --- master.cfg       (revision 57518)
> >> +++ master.cfg       (working copy)
> >> @@ -16,6 +16,8 @@
> >> import re
> >> import simplejson
> >>
> >> +from webkitpy.common.net.buildbot import BuildBot as wkbuildbot
> >> +
> >> WithProperties = properties.WithProperties
> >>
> >> class ConfigureBuild(buildstep.BuildStep):
> >> @@ -369,6 +371,9 @@
> >>
> >>    config = simplejson.load(open('config.json'))
> >>
> >> +    # use webkitpy's buildbot module to test for core builders
> >> +    wkbb = wkbuildbot()
> >> +
> >>    c['slaves'] = [BuildSlave(slave['name'], passwords[slave['name']],
> max_builds=1) for slave in config['slaves']]
> >>
> >>    c['schedulers'] = []
> >> @@ -397,6 +402,10 @@
> >>
> >>        builder["factory"] = factory(*factoryArgs)
> >>
> >> +        builder["category"] = "noncore"
> >> +        if wkbb._is_core_builder(builder['name']):
> >> +            builder["category"] = "core"
> >> +
> >>        c['builders'].append(builder)
> >>
> >> loadBuilderConfig(c)
> >>
> >>
> >>
> >>
> >> _______________________________________________
> >> webkit-dev mailing list
> >> webkit-dev at lists.webkit.org
> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100415/eb9bc71f/attachment.html>


More information about the webkit-dev mailing list