[webkit-dev] Proposal: commit-queue to fix usernames after commit

Eric Seidel eric at webkit.org
Mon Apr 12 16:56:51 PDT 2010

Currently the commit-queue commits all patches as "eric at webkit.org".
Some contributers have raised concerns that the commit queue does not
properly credit them for their changes (i.e. in svn annotate), or
concerns that the commit-queue should not be used by committers for
risk of incorrect attribution.

I spoke at length with Bill Siegrist this afternoon and we have a plan
whereby svn.webkit.org could fix svn:author properties on commit-queue

The proposal is to modify the SVN post-commit hook to:
1.  Grab the author email out of the incoming commit-message/ChangeLog
2.  Check to see if the author email is listed in the SVN authorization file.
3.  If the author is a committer, modify the svn:author property on
the commit (svn propset --revprop -r $REVISION svn:author
4.  Do all rest of the post-commit hooks.

We believe this plan would avoid any Git repository corruption, or
wrong authors in trac or emails as previous proposals for addressing
this issue may have had.

Unless there are objections from the rest of WebKit, Bill and I will
move forward with investigations in the next few weeks.

I would love to hear your feedback!


More information about the webkit-dev mailing list