[webkit-dev] Point 3 of the WebKit Style Guidelines (indenting code inside namespaces in headers)

Eric Seidel eric at webkit.org
Tue Sep 22 13:24:26 PDT 2009


I'm fine either way.  Will check-webkit-style need an update?  I think it might.

On Tue, Sep 22, 2009 at 1:23 PM, Sam Weinig <sam.weinig at gmail.com> wrote:
> I also think this change is the right way to go.  r=me.
>
> On Tue, Sep 22, 2009 at 1:20 PM, Brady Eidson <beidson at apple.com> wrote:
>>
>> I've always hated the indentation in header files.
>>
>> I have no objections.
>>
>> ~Brady
>>
>> On Sep 22, 2009, at 1:06 PM, David Hyatt wrote:
>>
>>> I had thought that we resolved ages ago that we would no longer be
>>> indenting code inside namespaces in header files, since that just results in
>>> the entire class declaration being pointlessly indented.
>>>
>>> This is point 3 on the page:
>>>
>>> http://webkit.org/coding/coding-style.html
>>>
>>> I'd like to reverse the Right and Wrong examples to fix this.
>>>
>>> Are there any objections to this change?  I know a few months ago, people
>>> agreed (notably Maciej) that there was no longer any point to essentially
>>> indenting the entire file's contents (when we already don't do this in .cpp
>>> files).
>>>
>>> dave
>>> (hyatt at apple.com)
>>>
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>


More information about the webkit-dev mailing list