[webkit-dev] [webkit-changes] [48407] trunk/LayoutTests

Adam Roben aroben at apple.com
Wed Sep 16 06:15:38 PDT 2009

On Sep 15, 2009, at 11:39 PM, cfleizach at apple.com wrote:

> +        This test should only be for Mac, since the other platforms  
> don't support the necessary features.
> +
> +        WAI-ARIA: add support for ranges, including the  
> progressbar, slider, and spinbutton roles
> +        https://bugs.webkit.org/show_bug.cgi?id=28841
> +
> +        * accessibility/aria-slider-value-change-expected.txt:  
> Removed.
> +        * accessibility/aria-slider-value-change.html: Removed.
> +        * platform/mac/accessibility/aria-slider-value-change- 
> expected.txt: Copied from LayoutTests/accessibility/aria-slider- 
> value-change-expected.txt.
> +        * platform/mac/accessibility/aria-slider-value-change.html:  
> Copied from LayoutTests/accessibility/aria-slider-value-change.html.

Is the test intrinsically Mac-only? Or is it just that Mac is the only  
platform that will currently pass the test?

If it's the former, moving the test to platform/mac (like you did) is  
the right thing. If it's the latter, then either the test should be  
added to the Skipped files for all the other platforms, or failing  
results should be checked in for all the other platforms. (I'm not  
sure which strategy we prefer these days.)


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090916/c69c26c6/attachment.html>

More information about the webkit-dev mailing list