[webkit-dev] take 2: unwritten rules of webkit style

David Levin levin at google.com
Thu Sep 3 17:35:33 PDT 2009

On Thu, Sep 3, 2009 at 4:04 PM, Gavin Barraclough <barraclough at apple.com>wrote:

> On Sep 3, 2009, at 3:51 PM, Peter Kasting wrote:
> On Thu, Sep 3, 2009 at 3:46 PM, Darin Adler <darin at apple.com> wrote:
>> On Sep 3, 2009, at 8:43 AM, David Levin wrote:
>> There should only be a single space before end of line comments. An
>> exception is if one is lining up several end of line comments.
>> I don’t think we should have this exception.
>> Things manually lined up in source code generally create a small
>> maintainability problem. You can’t rename things without re-lining things
>> up, and if you make other types code changes without noticing the lined-up
>> comments the code ends up looking messy an peculiar.
> The common place to do this is on a set of constants/enum values, where I
> don't think the objections you raise are a big deal.
> I don't think we normally allow an exception for this.
> (Personally I'd quite like it if we did, I prefer to constants aligned as
> you suggest – but rules is rules & this has not been allowed for me in the
> past).

Cool. I added that due to a side discussion, but it is good to know that it
hasn't been acceptable.

Before this gets added to the style guide, the exception will be removed.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20090903/77a0ca20/attachment.html>

More information about the webkit-dev mailing list